Switches integration tests to package firebase-tools (#5625)

* Switches integration tests to package firebase-tools instead of npm i && npm link * Make executable * PR fixes * pack to the correct location
firebase · Mar 29, 2023 · 616e9f6 · 616e9f6
1 parent 4f947cf
commit 616e9f6
Show file tree

Hide file tree

Showing 13 changed files with 32 additions and 18 deletions.
diff --git a/scripts/clean-install.sh b/scripts/clean-install.sh
@@ -0,0 +1,21 @@
+#!/bin/bash
+set -e
+
+function cleanup() {
+  echo "Cleaning up artifacts..."
+  rm -rf ./clean
+  echo "Artifacts deleted."
+}
+
+trap cleanup EXIT
+
+echo "Running clean-publish --without-publish, as we would before publishing to npm..."
+npx clean-publish --without-publish --before-script ./scripts/clean-shrinkwrap.sh --temp-dir clean
+echo "Ran clean-publish --without-publish."
+echo "Packaging cleaned firebase-tools..."
+cd ./clean
+PACKED=$(npm pack --pack-destination ./ | tail -n 1)
+echo "Packaged firebase-tools to $PACKED."
+echo "Installing clean-packaged firebase-tools..."
+npm install -g $PACKED
+echo "Installed clean-packaged firebase-tools."
diff --git a/scripts/emulator-import-export-tests/run.sh b/scripts/emulator-import-export-tests/run.sh
@@ -1,6 +1,6 @@
 #!/bin/bash
 
 source scripts/set-default-credentials.sh
-./scripts/npm-link.sh
+./scripts/clean-install.sh
 
 npx mocha --exit scripts/emulator-import-export-tests/tests.ts
diff --git a/scripts/extensions-deploy-tests/run.sh b/scripts/extensions-deploy-tests/run.sh
@@ -2,6 +2,6 @@
 set -e # Immediately exit on failure
 
 # Globally link the CLI for the testing framework
-./scripts/npm-link.sh
+./scripts/clean-install.sh
 
 mocha scripts/extensions-deploy-tests/tests.ts
diff --git a/scripts/extensions-emulator-tests/run.sh b/scripts/extensions-emulator-tests/run.sh
@@ -1,7 +1,7 @@
 #!/bin/bash
 
 source scripts/set-default-credentials.sh
-./scripts/npm-link.sh
+./scripts/clean-install.sh
 
 (
   cd scripts/extensions-emulator-tests/functions

diff --git a/scripts/frameworks-tests/run.sh b/scripts/frameworks-tests/run.sh
@@ -10,7 +10,7 @@ echo "Running with Application Creds: ${GOOGLE_APPLICATION_CREDENTIALS}"
 echo "Target project: ${FBTOOLS_TARGET_PROJECT}"
 
 echo "Installing firebase-tools..."
-./scripts/npm-link.sh
+./scripts/clean-install.sh
 echo "Installed firebase-tools: $(which firebase)"
 
 echo "Enabling experiment..."

diff --git a/scripts/functions-deploy-tests/run.sh b/scripts/functions-deploy-tests/run.sh
@@ -2,7 +2,7 @@
 set -e # Immediately exit on failure
 
 # Globally link the CLI for the testing framework
-./scripts/npm-link.sh
+./scripts/clean-install.sh
 
 # Create a secret for testing if it doesn't exist
 firebase functions:secrets:get TOP --project $GCLOUD_PROJECT || (echo secret | firebase functions:secrets:set --data-file=- TOP --project $GCLOUD_PROJECT -f)

diff --git a/scripts/functions-discover-tests/run.sh b/scripts/functions-discover-tests/run.sh
@@ -3,7 +3,7 @@ set -euxo pipefail # bash strict mode
 IFS=$'\n\t'
 
 # Globally link the CLI for the testing framework
-./scripts/npm-link.sh
+./scripts/clean-install.sh
 
 # Unlock internal commands for discovering functions in a project.
 firebase experiments:enable internaltesting

diff --git a/scripts/hosting-tests/run.sh b/scripts/hosting-tests/run.sh
@@ -22,7 +22,7 @@ TEMP_DIR="$(mktemp -d)"
 echo "Created temp directory: ${TEMP_DIR}"
 
 echo "Installing firebase-tools..."
-./scripts/npm-link.sh
+./scripts/clean-install.sh
 echo "Installed firebase-tools: $(which firebase)"
 
 echo "Initializing temp directory..."

diff --git a/scripts/npm-link.sh b/scripts/npm-link.sh
diff --git a/scripts/storage-deploy-tests/run.sh b/scripts/storage-deploy-tests/run.sh
@@ -23,7 +23,7 @@ TEMP_DIR="$(mktemp -d)"
 echo "Created temp directory: ${TEMP_DIR}"
 
 echo "Installing firebase-tools..."
-./scripts/npm-link.sh
+./scripts/clean-install.sh
 echo "Installed firebase-tools: $(which firebase)"
 
 echo "Initializing temp directory..."

diff --git a/scripts/storage-emulator-integration/run.sh b/scripts/storage-emulator-integration/run.sh
@@ -2,7 +2,7 @@
 set -e # Immediately exit on failure
 
 # Globally link the CLI for the testing framework
-./scripts/npm-link.sh
+./scripts/clean-install.sh
 
 # Set application default credentials.
 source scripts/set-default-credentials.sh

diff --git a/scripts/triggers-end-to-end-tests/run.sh b/scripts/triggers-end-to-end-tests/run.sh
@@ -19,7 +19,7 @@ function cleanup() {
 trap cleanup EXIT
 
 source scripts/set-default-credentials.sh
-./scripts/npm-link.sh
+./scripts/clean-install.sh
 
 for dir in triggers v1 v2; do
   (

diff --git a/scripts/webframeworks-deploy-tests/run.sh b/scripts/webframeworks-deploy-tests/run.sh
@@ -2,7 +2,7 @@
 set -e # Immediately exit on failure
 
 # Globally link the CLI for the testing framework
-./scripts/npm-link.sh
+./scripts/clean-install.sh
 
 (cd scripts/webframeworks-deploy-tests/hosting; npm i; npm run build)