Skip to content

Commit

Permalink
Merge 9351304 into 7c01343
Browse files Browse the repository at this point in the history
  • Loading branch information
joehan committed Jan 8, 2019
2 parents 7c01343 + 9351304 commit ceac76e
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 1 deletion.
4 changes: 3 additions & 1 deletion changelog.txt
Expand Up @@ -6,4 +6,6 @@ fixed - Fixed an error that occurs when a Firestore field override removes all i
feature - Firestore emulator now has the ability to produce rule-coverage reports
changed - Firestore emulator now exposes the v1 service definition
changed - Firestore emulator has various runtime improvements
changed - Clearer empty state when pretty-printing Firestore indexes
changed - Clearer empty state when pretty-printing Firestore indexes
changed - JavasSript functions template now includes gitignore
changed - Added node_modules/ to TypeScript functions template gitignore
4 changes: 4 additions & 0 deletions src/init/features/functions/javascript.js
Expand Up @@ -18,6 +18,7 @@ var PACKAGE_NO_LINTING_TEMPLATE = fs.readFileSync(
"utf8"
);
var ESLINT_TEMPLATE = fs.readFileSync(path.join(TEMPLATE_ROOT, "eslint.json"), "utf8");
var GITIGNORE_TEMPLATE = fs.readFileSync(path.join(TEMPLATE_ROOT, "_gitignore"), "utf8");

module.exports = function(setup, config) {
return prompt(setup.functions, [
Expand All @@ -42,6 +43,9 @@ module.exports = function(setup, config) {
.then(function() {
return config.askWriteProjectFile("functions/index.js", INDEX_TEMPLATE);
})
.then(function() {
return config.askWriteProjectFile("functions/.gitignore", GITIGNORE_TEMPLATE);
})
.then(function() {
return npmDependencies.askInstallDependencies(setup, config);
});
Expand Down
1 change: 1 addition & 0 deletions templates/init/functions/javascript/_gitignore
@@ -0,0 +1 @@
node_modules/
2 changes: 2 additions & 0 deletions templates/init/functions/typescript/_gitignore
Expand Up @@ -4,3 +4,5 @@

# Typescript v1 declaration files
typings/

node_modules/

0 comments on commit ceac76e

Please sign in to comment.