-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No graceful exit using NPM Scripts #2507
Comments
@kellyjandrews hmmm I am not able to reproduce this, here are my logs:
It does seem like a bug that you're getting the same PID for all emulators though ... |
Fixing the wrong PID issue in #2511 ... still not sure why you're seeing double Ctrl+C though. Is it possible it's your Macbook keyboard acting up? Mine does double keypresses all the time. |
When I run the command directly - It sounds like Thanks for looking into it. Filed a question over at NPM to see if it's something intended or a bug - npm/cli#1591 |
@kellyjandrews oh sorry I missed the part about it being part of |
@samtstern No problem - closed this for now as it seems like it's more of an NPM problem - but if not we can reopen. I'll keep you posted. |
@kellyjandrews I have a fix incoming for this issue. |
@samtstern that's amazing - thanks so much! |
This seems to have been fixed in August 2020 with : I don't know if there was some kind of regression recently, but I have just encountered the issue described in this original issue report. In my case, adding --debug did not help. Here is how I am using it in NodeJS :
Should I post all the details as a comment in this issue or open a new issue ? |
@guillaumeprevost yes please open a new issue with steps to reproduce! The simpler the better. |
[REQUIRED] Environment info
firebase-tools: 8.6.0
Platform: macOS
[REQUIRED] Test case
Setup a firebase project that uses the emulators.
[REQUIRED] Steps to reproduce
Start the emulators through
npm start
. I'm currently using hosting, functions and firestore.Stop emulators using
CTRL-C
[REQUIRED] Expected behavior
A graceful exit.
[REQUIRED] Actual behavior
Ironically, with
--debug
it does not fail.Not sure why it's getting the second SIGINT, or if there is any way to prevent it from happening. Let me know if there is something I can change on my end to fix it directly as well. Thanks!
The text was updated successfully, but these errors were encountered: