Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service_location not passed to dataconnect binary. #7217

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix service_location not passed to dataconnect binary. #7217

merged 2 commits into from
May 24, 2024

Conversation

yuchenshi
Copy link
Member

Description

See title

Scenarios Tested

Ran firebase emulators:start locally and looked at pgrep -a dataconnect full command line to make sure the argument gets passed

Sample Commands

@yuchenshi yuchenshi requested a review from fredzqm May 24, 2024 01:10
@yuchenshi yuchenshi enabled auto-merge (squash) May 24, 2024 01:12
@yuchenshi yuchenshi merged commit 45a5718 into master May 24, 2024
35 checks passed
@yuchenshi yuchenshi deleted the ys/fdc-service-location-arg branch May 24, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredzqm fredzqm fredzqm approved these changes

Assignees

@fredzqm fredzqm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuchenshi @fredzqm