Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project ID when deleting all collections #1025

Merged
merged 1 commit into from Nov 19, 2018
Merged

Add project ID when deleting all collections #1025

merged 1 commit into from Nov 19, 2018

Conversation

samtstern
Copy link
Contributor

Fixes #1009

screen shot 2018-11-19 at 1 45 28 pm

cc @mikelehen

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Nov 19, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.536% when pulling ea93534 on ss-delete-warning into ddcaf52 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.536% when pulling ea93534 on ss-delete-warning into ddcaf52 on master.

mikelehen
mikelehen reviewed Nov 19, 2018
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks! :)

bkendall
bkendall approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@bkendall bkendall left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm adding Alex as a reviewer (might as well have another sanity check)

@bkendall
Copy link
Contributor

please "Squash and merge", @samtstern!

@samtstern samtstern merged commit ee0995c into master Nov 19, 2018
@bkendall bkendall deleted the ss-delete-warning branch November 20, 2018 18:46
@snyk-bot snyk-bot mentioned this pull request Dec 19, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Jul 5, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikelehen mikelehen mikelehen left review comments

@bkendall bkendall bkendall approved these changes

@Memeriaj Memeriaj Memeriaj approved these changes

@mbleigh mbleigh Awaiting requested review from mbleigh

Assignees

@Memeriaj Memeriaj

@samtstern samtstern

Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@samtstern @coveralls @bkendall @mikelehen @Memeriaj @googlebot