Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use overall Functions lifecycle hook for individual function deploy #1217

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Use overall Functions lifecycle hook for individual function deploy #1217

merged 1 commit into from
Apr 24, 2019

Conversation

yzalvov
Copy link
Contributor

@yzalvov yzalvov commented Apr 24, 2019

In conclusion of the #1213, #1215 and #1216

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Apr 24, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.557% when pulling 5ba04af on yzalvov:fix/single-func-deploy into d67ecfa on firebase:master.

@Memeriaj
Copy link
Contributor

Woot! Everything has come together.

@yzalvov
Copy link
Contributor Author

yzalvov commented Apr 24, 2019

Great! So @Memeriaj do you want me to close #1213 and #1215 then?

@Memeriaj
Copy link
Contributor

Yes please.

@Memeriaj
Copy link
Contributor

Are you able to "Squash and merge" the PR? Or do I need to do it?

@yzalvov
Copy link
Contributor Author

yzalvov commented Apr 24, 2019

I'm not sure. Part Only those with write access to this repository can merge pull requests. looks not promising. Here's the UI I have:

Screenshot 2019-04-25 at 01 13 14

@Memeriaj
Copy link
Contributor

Okay, no sweat. We typically do squash and merges because they tend to make the history cleaner (one commit on master per PR) but since this is just one commit and if I do a squash and merge it'll rewrite the commit to be mine, I'm just going to do a normal merge.

@Memeriaj Memeriaj merged commit c148248 into firebase:master Apr 24, 2019
@yzalvov yzalvov deleted the fix/single-func-deploy branch April 25, 2019 09:55
@yzalvov
Copy link
Contributor Author

yzalvov commented Apr 25, 2019

@Memeriaj many thanks for help. Please clarify, how long does it usually take to have a fix like this to be pushed to NPM so that yarn upgrade fixes the local version?

@Memeriaj
Copy link
Contributor

On average we do a release every couple of days. Depending on how busy I am this afternoon I'll try to do one myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants