Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mocha's old 'exit-on-complete' behavior #1233

Closed
wants to merge 2 commits into from
Closed

Use mocha's old 'exit-on-complete' behavior #1233

wants to merge 2 commits into from

Conversation

ryanpbrewster
Copy link
Contributor

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label May 1, 2019
@coveralls
Copy link

coveralls commented May 1, 2019 •
edited

Coverage Status

Coverage remained the same at 62.071% when pulling 0e1641f on rpb/mocha-exit into 551e1d7 on master.

@ryanpbrewster
Copy link
Contributor Author

Closing this PR, best practice is probably to clean up tests properly and --exit hides those kind of failures.

@ryanpbrewster ryanpbrewster deleted the rpb/mocha-exit branch May 1, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkendall bkendall Awaiting requested review from bkendall

Assignees

@bkendall bkendall

Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryanpbrewster @coveralls @bkendall @googlebot