Refactor listPath API for size node API in #1272
#1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irebase/firebase-tools into wyszynski/list-remote-refactor
…irebase/firebase-tools into wyszynski/list-remote-refactor
bkendall
requested changes
May 17, 2019
fredzqm
requested changes
May 17, 2019
…m/firebase/firebase-tools into wyszynski/list-remote-refactor-v2
jmwski
requested review from
fredzqm and
bkendall
and removed request for
fredzqm
bkendall
approved these changes
May 20, 2019
fredzqm
approved these changes
May 30, 2019
ryanpbrewster
approved these changes
May 30, 2019
| path: string, | ||
| numSubPath: number, | ||
| startAfter?: string, | ||
| timeout?: number |
There was a problem hiding this comment.
let's name this timeoutMs to indicate what the semantics are
| path: string, | ||
| numChildren: number, | ||
| startAfter?: string, | ||
| timeout?: number |
| keys = keys.slice(0, numChildren); | ||
| return keys; | ||
| } | ||
| return []; |
There was a problem hiding this comment.
nit: can reduce complexity by saying let keys = Object.keys(d || {}) (or by switching this to an early return)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is both
npm testandnpm installclean.Description
This is a refactor that #1239 depends on.
Scenarios Tested
Modified tests and existing test suite pass.
Sample Commands