Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Cloud Firestore emulator v1.4.6 #1318

Merged
merged 3 commits into from May 20, 2019
Merged

Conversation

ryanpbrewster
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label May 20, 2019
@ryanpbrewster ryanpbrewster changed the title Rpb/firestore v1.4.6 Release Cloud Firestore emulator v1.4.6 May 20, 2019
changelog.txt Outdated Show resolved Hide resolved
Co-Authored-By: Bryan Kendall <bryan.a.kendall@gmail.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes Manual indication that this has passed CLA. labels May 20, 2019
@ryanpbrewster ryanpbrewster added cla: yes Manual indication that this has passed CLA. and removed cla: no labels May 20, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.078% when pulling 6b0c0a7 on rpb/firestore-v1.4.6 into b6f36a8 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.078% when pulling 6b0c0a7 on rpb/firestore-v1.4.6 into b6f36a8 on master.

@coveralls
Copy link

coveralls commented May 20, 2019

Coverage Status

Coverage increased (+0.05%) to 62.132% when pulling 4434ee6 on rpb/firestore-v1.4.6 into b6f36a8 on master.

@ryanpbrewster ryanpbrewster merged commit 1c6f708 into master May 20, 2019
@ryanpbrewster ryanpbrewster deleted the rpb/firestore-v1.4.6 branch May 20, 2019 22:52
@@ -0,0 +1,2 @@
* Fixed bug in Firestore emulator where some FieldTransforms were sending back incorrect results.
* Added support for read-only transactions to Firestore emulator.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This release also seemed to have fixed collection group queries on listen streams.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@firebase/testing does not handle FieldValue.increment #1799 is still not fixed. I'm starting a brand new firebase project today, I still have the extact same proplem with most recent packages installed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open a new issue with specific details of what you're trying to do and what's failing.

This specific issue definitely was fixed because it was blocking being able to run the Firestore SDK integration test suite against the emulator. Since this release we've been able to do that successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants