Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify functions emulator to invoke RTDB emulator triggers #1347

Merged
merged 21 commits into from Jun 5, 2019

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented May 30, 2019

Description

This change is part of the effort to integrate the RTDB emulator with the functions emulator.

Scenarios Tested

I have tested starting up a local RTDB emulator and a functions emulator that registers a single function to be called onWrite. I then wrote to the corresponding location in the RTDB emulator an observed that the function is called.

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label May 30, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 61.154% when pulling 783d764 on wyszynski/rtdb-emulator-functions into 08f053e on master.

@coveralls
Copy link

coveralls commented May 30, 2019

Coverage Status

Coverage decreased (-0.4%) to 61.533% when pulling f4010dd on wyszynski/rtdb-emulator-functions into 57101c4 on next.

src/emulator/functionsEmulator.ts Outdated Show resolved Hide resolved
src/emulator/functionsEmulator.ts Outdated Show resolved Hide resolved
src/emulator/constants.ts Show resolved Hide resolved
@yuchenshi yuchenshi removed their assignment May 30, 2019
src/emulator/functionsEmulator.ts Outdated Show resolved Hide resolved
src/emulator/functionsEmulator.ts Outdated Show resolved Hide resolved
@jmwski jmwski requested a review from yuchenshi May 30, 2019 20:07
yuchenshi
yuchenshi previously approved these changes May 30, 2019
@yuchenshi yuchenshi removed their assignment May 30, 2019
@yuchenshi yuchenshi dismissed their stale review May 30, 2019 20:41

WANT_LGTM=abeisgoat

Copy link
Contributor

@samtstern samtstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The regex stuff is hairier than I'd like but looks about as clean as it can be!

@samtstern
Copy link
Contributor

@IanWyszynski should we put this on master or start a rtdb-emulator branch? I think this needs to be paired with a PR to update the RTDB jar at least and I wouldn't want this to accidentally get partially released.

@yuchenshi
Copy link
Member

@samtstern Let's keep this PR open until we have a new RTDB jar and this PR can then be amended to also include the change to the jar URL and checksum. In this way, the whole PR is atomic and roll back safe.

@jmwski jmwski changed the base branch from master to next June 4, 2019 20:39
@jmwski jmwski requested a review from bkendall June 4, 2019 20:40
@jmwski
Copy link
Contributor Author

jmwski commented Jun 5, 2019

@yuchenshi I merged b0c58ab into the next before I saw your suggestion about keeping all the changes in the PR. It seemed like have a separate PR for releases was consistent with the practice for other emulators. However, I've added the changes in that PR to this one so at least we have the whole diff in one place.

@yuchenshi
Copy link
Member

@IanWyszynski Your call :) I think we're in a good spot to merge this to next. Hit it?

@jmwski jmwski merged commit 5211925 into next Jun 5, 2019
@thechenky
Copy link
Contributor

@IanWyszynski make sure to squash and merge (instead of just merging) so it's all contained in one commit.

@bkendall bkendall deleted the wyszynski/rtdb-emulator-functions branch August 4, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA. emulators: functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants