Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support FIRESTORE_EMULATOR_HOST variable #1376

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Support FIRESTORE_EMULATOR_HOST variable #1376

merged 3 commits into from
Jun 7, 2019

Conversation

samtstern
Copy link
Contributor

The @firebase/testing SDK now supports both and all other SDKs now prefer FIRESTORE_EMULATOR_HOST so we should prefer that one (but still set both).

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Jun 6, 2019
@coveralls
Copy link

coveralls commented Jun 6, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 62.335% when pulling 7087a66 on ss-fix-env-vars into e36933b on master.

ryanpbrewster
ryanpbrewster approved these changes Jun 6, 2019
View reviewed changes
src/commands/emulators-exec.ts Outdated Show resolved Hide resolved
src/emulator/firestoreEmulator.ts Show resolved Hide resolved
@samtstern samtstern merged commit 62a7fcb into master Jun 7, 2019
@samtstern samtstern deleted the ss-fix-env-vars branch June 20, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanpbrewster ryanpbrewster ryanpbrewster approved these changes

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samtstern @coveralls @ryanpbrewster @googlebot