register rtdb triggers per-namespace in functions emulator #1413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the original commit used to wire together the functions emulator with the database emulator, we did not register function triggers per-namespace. Without a namespace query paramter (
ns
), the RTDB emulator assumes the request is for a special fake sentinel namespace called 'fake-server'. This is confusing because developers may expect that the function emulator registers triggers with a namespace whose name matches the project id of their currently active firebase project.In the current state of things, writes to a namespace whose name matches the active firebase project id would not trigger RTDB functions because those triggers are always registered with the sentinel namespace.
Scenarios Tested
I tested triggering an RTDB function for a specified namespace, something like:
Sample Commands