New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Firebase Admin Stubbing #1459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I still cannot get my head around the three layers of stubbing involved in this PR (JS proxy, Node.js require cache, fake creds) and I'm not familiar with the code base. But I'm sure it will be fine somehow.
WANT_LGTM=abeisgoat
@yuchenshi thanks for taking a look. I agree with waiting for @abeisgoat |
Waiting on @abeisgoat to take a final pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good as long as there aren't any logic changes in the big function
Description
Fixes issue #1454
This investigation took me very deep and along the way I also:
Scenarios Tested
Using these functions to test:
I also added a unit test that verifies the same behavior.
Sample Commands
N/A