Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize integration tests #1493

Merged
merged 6 commits into from Jul 11, 2019
Merged

Parallelize integration tests #1493

merged 6 commits into from Jul 11, 2019

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Jul 11, 2019

Right now the hosting functional test and the emulators end-to-end tests are run in sequence but there is no need. Moving it into one stage removes some overhead and speeds things up by about 2 minutes.

This PR - 5m33s
Screenshot from 2019-07-11 09-55-23

Other Recent PR - 7m48s
Screenshot from 2019-07-11 09-55-38

The environment variables help distinguish the tests in the Travis UI:
image

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Jul 11, 2019
@samtstern samtstern requested a review from bkendall July 11, 2019 16:57
@samtstern samtstern changed the title [WIP] Parallelize integration tests [Parallelize integration tests Jul 11, 2019
@samtstern samtstern changed the title [Parallelize integration tests Parallelize integration tests Jul 11, 2019
@coveralls
Copy link

coveralls commented Jul 11, 2019

Coverage Status

Coverage decreased (-0.05%) to 61.884% when pulling 5caa99f on ss-integration-tests into f56b29c on master.

@samtstern samtstern merged commit 308622d into master Jul 11, 2019
@samtstern
Copy link
Contributor Author

@bkendall I ran into my least favorite bug on this PR: I hit Ctrl+Enter instead of mouse-clicking "Squash and Merge" and therefore it merged all my commits into master (despite the UI saying otherwise)

@samtstern samtstern deleted the ss-integration-tests branch July 23, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants