Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade chokidar #1539

Merged
merged 2 commits into from Jul 24, 2019
Merged

upgrade chokidar #1539

merged 2 commits into from Jul 24, 2019

Conversation

bkendall
Copy link
Contributor

Description

chokidar seems to actually have a ton of dependencies that are cleaned up and simplified when upgrading to v3 (from v2).

@abeisgoat - I think you'll like this quote in particular from their blog:

Switching node-fsevents to N-API, a new API for building native addons. In v2, we’ve been using node-gyp, which is buggy, sloppy, and produced useless errors while compiling.

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Jul 23, 2019
@coveralls
Copy link

coveralls commented Jul 23, 2019 •
edited

Coverage Status

Coverage decreased (-0.04%) to 61.609% when pulling b5b8831 on bk-chokidar into 530fa3f on master.

@samtstern
Copy link
Contributor

@bkendall seems like rules-watching still works after this so LGTM

@samtstern
Copy link
Contributor

Also that blog post is fantastic.

@bkendall bkendall merged commit 666b860 into master Jul 24, 2019
@bkendall bkendall deleted the bk-chokidar branch August 1, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtstern samtstern samtstern approved these changes

@abeisgoat abeisgoat Awaiting requested review from abeisgoat

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkendall @coveralls @samtstern @googlebot