Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelog.txt -> changelog.md #1565

Merged
merged 2 commits into from Jul 30, 2019
Merged

changelog.txt -> changelog.md #1565

merged 2 commits into from Jul 30, 2019

Conversation

bkendall
Copy link
Contributor

Description

Change changelog.txt to be changelog.md, better reflecting the type the file should be.

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Jul 30, 2019
mbleigh
mbleigh approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@mbleigh mbleigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're changing it anyway, should it be CHANGELOG.md to better match GitHub naming standards?

@coveralls
Copy link

coveralls commented Jul 30, 2019 •
edited

Coverage Status

Coverage remained the same at 63.942% when pulling b762c25 on bk-changelog-markdown into 509a49b on master.

@bkendall bkendall requested a review from mbleigh July 30, 2019 17:24
@bkendall bkendall merged commit ffcdd55 into master Jul 30, 2019
@bkendall bkendall deleted the bk-changelog-markdown branch July 30, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbleigh mbleigh mbleigh approved these changes

@thechenky thechenky thechenky approved these changes

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bkendall @coveralls @mbleigh @thechenky @googlebot