Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix local auth message #1620

Merged
merged 4 commits into from Aug 28, 2019
Merged

fix local auth message #1620

merged 4 commits into from Aug 28, 2019

Conversation

bkendall
Copy link
Contributor

Description

Login looks like this now (with localhost):

:~ » firebase login --reauth
i  Firebase optionally collects CLI usage and error reporting information to help improve our products. Data is collected in accordance with Google's privacy policy (https://policies.google.com/privacy) and is not used to identify you.

? Allow Firebase to collect CLI usage and error reporting information? No

Visit this URL on this device to log in:
[url]

Waiting for authentication...

Scenarios Tested

login with localhost, and login --no-localhost which looks like:

:~ » firebase login --reauth --no-localhost
i  Firebase optionally collects CLI usage and error reporting information to help improve our products. Data is collected in accordance with Google's privacy policy (https://policies.google.com/privacy) and is not used to identify you.

? Allow Firebase to collect CLI usage and error reporting information? No

Visit this URL on any device to log in:
[url]

? Paste authorization code here:

Fixes #1596

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Aug 23, 2019
@coveralls
Copy link

coveralls commented Aug 23, 2019

Coverage Status

Coverage increased (+0.04%) to 65.088% when pulling 7fbf873 on bk-fix-login-message into 61a459c on master.

@bkendall bkendall merged commit a9881ed into master Aug 28, 2019
@bkendall bkendall deleted the bk-fix-login-message branch August 28, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot login from different device
5 participants