Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update extensions registry URL #1731

Merged
merged 5 commits into from Nov 14, 2019
Merged

update extensions registry URL #1731

merged 5 commits into from Nov 14, 2019

Conversation

bkendall
Copy link
Contributor

Description

Update Extensions registry URL

Scenarios Tested

  • firebase ext:info storage-resize-images@0.1.1
  • firebase ext:info storage-resize-images@0.1.0

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Oct 17, 2019
@laurenzlong
Copy link
Contributor

I'm having second thoughts on whether we want to do this. Since the old link is already out in a publicly released version of the CLI, making this change would mean that we would have to forever maintain 2 registry links - and it's a bad idea to have 2 sources of truth. I'm tempted to just keep using mods-registry for CLI, Console, and Firesite and abandon extensions-registry.

@coveralls
Copy link

coveralls commented Oct 17, 2019

Coverage Status

Coverage increased (+0.04%) to 66.258% when pulling 8d66aca on bkendall-patch-1 into 48e7f27 on master.

Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, as long as we are settled on taking this approach

@bkendall
Copy link
Contributor Author

I added a changelog entry to this, in case anyone wants to take a look...

@bkendall bkendall merged commit d02c287 into master Nov 14, 2019
@bkendall bkendall deleted the bkendall-patch-1 branch November 14, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants