Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the debug logging for the large delete CLI #1747

Merged
merged 6 commits into from Oct 29, 2019
Merged

Improve the debug logging for the large delete CLI #1747

merged 6 commits into from Oct 29, 2019

Conversation

fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Oct 24, 2019 •
edited

There is a customer asking why deletes on these path failed, but in fact the tool will retry them.
I am updating the logging to be more clear on that.

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Oct 24, 2019
@fredzqm fredzqm requested a review from bkendall October 24, 2019 21:00
@bkendall
Copy link
Contributor

Run the formatter on your branch (npm run format)

@fredzqm
Copy link
Contributor Author

fredzqm commented Oct 24, 2019

Done. Sorry, forgot that step.

@coveralls
Copy link

coveralls commented Oct 24, 2019 •
edited

Coverage Status

Coverage remained the same at 66.173% when pulling 2074c54 on fz/impro-logging into 079f009 on master.

@samtstern samtstern merged commit 22ce97f into master Oct 29, 2019
@bkendall bkendall deleted the fz/impro-logging branch April 10, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkendall bkendall bkendall approved these changes

@samtstern samtstern samtstern approved these changes

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fredzqm @bkendall @coveralls @samtstern @googlebot