Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up old bug references #1792

Merged
merged 3 commits into from Nov 14, 2019
Merged

Cleaning up old bug references #1792

merged 3 commits into from Nov 14, 2019

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Nov 13, 2019

Description

Cleans up some references to an old internal bug, and sets Nock to check for a pageSize

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Nov 13, 2019
@joehan joehan requested a review from bkendall November 13, 2019 18:21
@coveralls
Copy link

coveralls commented Nov 13, 2019 •
edited

Coverage Status

Coverage remained the same at 66.24% when pulling 2eab74c on jh-remove-qp into ab51675 on master.

@joehan joehan merged commit a8cde5f into master Nov 14, 2019
@joehan joehan deleted the jh-remove-qp branch November 14, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkendall bkendall bkendall approved these changes

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joehan @coveralls @bkendall @googlebot