New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds firepit-builder #1844
Adds firepit-builder #1844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing in the package.json
(might have to update package-lock.json
too)
scripts/firepit-builder/package.json
Outdated
}, | ||
"keywords": [], | ||
"author": "", | ||
"license": "ISC", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MIT
to match the repo.
And add "private": true
since this should never be published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done & done brudda
I never actually checked in the Dockerfile and pipeline script which live in our
firepit-builder
image, so adding those now. Will do another PR in a bit which adds a README for local building / testing of firepit, but wanted to get this in.