New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CI from Travis to GitHub Actions #1895
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
changed the title
[WIP] Experimenting with GitHub actions
[RFC] Move CI from Travis to GitHub Actions
Jan 3, 2020
bkendall
requested changes
Jan 6, 2020
@mbleigh added node |
bkendall
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me (a couple of nitty things).
Once we move to this, we should remove Travis as a requirement for PRs and add these new actions as the requirement.
samtstern
commented
Jan 7, 2020
samtstern
changed the title
[RFC] Move CI from Travis to GitHub Actions
Move CI from Travis to GitHub Actions
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Travis CI has been a huge source of delays lately because we often get "stuck in line" behind other Firebase repos that take 1h+ to build even though our build is only a few minutes.
GitHub actions is a new service from GitHub. This PR moves our CI pipeline to GitHub actions. This has a few benefits:
Build time seems similar or better, builds are completing in about ~3.5m for unit tests and ~1.5m for integration tests.
TODO:
Scenarios Tested
All tests ported.
Sample Commands
N/A