Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI from Travis to GitHub Actions #1895

Merged
merged 53 commits into from Jan 8, 2020
Merged

Move CI from Travis to GitHub Actions #1895

merged 53 commits into from Jan 8, 2020

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Jan 3, 2020

Description

Travis CI has been a huge source of delays lately because we often get "stuck in line" behind other Firebase repos that take 1h+ to build even though our build is only a few minutes.

GitHub actions is a new service from GitHub. This PR moves our CI pipeline to GitHub actions. This has a few benefits:

  1. Alleviate resource constraint issues with Travis.
  2. Better align us with the Open Source future at Google, as we have been told that GitHub Actions will be "blessed" in the future by the OSPO.

Build time seems similar or better, builds are completing in about ~3.5m for unit tests and ~1.5m for integration tests.

TODO:

Scenarios Tested

All tests ported.

Sample Commands

N/A

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Jan 3, 2020
@coveralls
Copy link

coveralls commented Jan 3, 2020

Coverage Status

Coverage increased (+0.4%) to 65.58% when pulling 8d16e40 on ss-github-actions into 9ee8f54 on master.

@samtstern samtstern changed the title [WIP] Experimenting with GitHub actions [RFC] Move CI from Travis to GitHub Actions Jan 3, 2020
.github/workflows/node-test.yml Outdated Show resolved Hide resolved
.github/workflows/node-test.yml Outdated Show resolved Hide resolved
.github/workflows/node-test.yml Outdated Show resolved Hide resolved
.github/workflows/node-test.yml Outdated Show resolved Hide resolved
.github/workflows/node-test.yml Outdated Show resolved Hide resolved
@samtstern
Copy link
Contributor Author

@mbleigh added node 12.x thanks for the idea.

Copy link
Contributor

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me (a couple of nitty things).

Once we move to this, we should remove Travis as a requirement for PRs and add these new actions as the requirement.

.github/workflows/node-test.yml Outdated Show resolved Hide resolved
scripts/set-default-credentials.sh Outdated Show resolved Hide resolved
@samtstern samtstern reopened this Jan 8, 2020
@samtstern samtstern changed the title [RFC] Move CI from Travis to GitHub Actions Move CI from Travis to GitHub Actions Jan 8, 2020
@samtstern samtstern merged commit eb91358 into master Jan 8, 2020
@bkendall bkendall deleted the ss-github-actions branch August 4, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants