Improves "emulators:start" logs

[abeisgoat]

Updates emulators:start to show...

✔  emulators: All emulators started, it is now safe to connect.
┌───────────┬────────────────┬─────────────────────────────────┐
│ Emulator  │ Host:Port      │ View in Browser                 │
├───────────┼────────────────┼─────────────────────────────────┤
│ Functions │ localhost:5001 │ http://localhost:4001/functions │
├───────────┼────────────────┼─────────────────────────────────┤
│ Firestore │ localhost:8080 │ http://localhost:4001/firestore │
├───────────┼────────────────┼─────────────────────────────────┤
│ Database  │ localhost:9000 │ http://localhost:4001/database  │
├───────────┼────────────────┼─────────────────────────────────┤
│ Hosting   │ localhost:5000 │                                 │
├───────────┼────────────────┼─────────────────────────────────┤
│ Pubsub    │ localhost:8085 │                                 │
└───────────┴────────────────┴─────────────────────────────────┘

You can also view status and logs of the emulators by pointing your browser to http://localhost:4001/.

Issues? Report them at https://github.com/firebase/firebase-tools/issues and attach log files named *-debug.log in current directory.

[yuchenshi]

Could you please also post a screenshot and a full log of all messages printed during start? I think we can clean up more cruft and we can talk more about it on chats.

[abeisgoat]

Here's current logs, we could potentially drop the messages for with port and debug log file for each emulator and move the log file name into the table. That plus removing all the GUI setup logic which prints out will help

[samtstern]

@abeisgoat how does this kind of thing look in the logging emulator? And yeah let's definitely remove the {emulator} started at {address} messages above the table, those are dupes now.

[abeisgoat]

Another pass based on feedback from bash.

@samtstern it breaks terribly, open to feedback about how we should handle it.

[samtstern]

@abeisgoat logs LGTM but I am worried about how it looks in the logs viewer. Can we just omit it somehow? Maybe add a new utils.logFancy or something like that?

I assume that for things like the emulator download progress bar or ora spinners we don't go through our normal logger. Tables should probably be the same.

[abeisgoat]

@samtstern we could def just write it to stdout which would pass the logger. prolly the best call. I'll do that fix and wait for @yuchenshi lgtm

[abeisgoat]

One more pass, the only concern is that the table is 86 characters wide and breaks anytime the console is less than that. Do we can? idk

[abeisgoat]

also got it looking correct in the logs viewer

[yuchenshi]

One more pass, the only concern is that the table is 86 characters wide and breaks anytime the console is less than that. Do we can? idk

I have but one suggestion -- remove log files from the table and throw them into the Issues? line since they are only needed for troubleshooting and bug reports. This way we can make the table width safe enough.

As a side topic, we should consider surfacing those logs in the GUI logs viewer once the logs transportation changes are in (maybe with log level "DEBUG" or "VERBOSE") and then there will be even one less reason to inspect the files manually. Especially the rules debug and rejection logs in Firestore emulator.

[abeisgoat]

note to self: move hub port to "other reserved ports" line

[abeisgoat]

another pass

[abeisgoat]

aight, one more time, thoughts / complaints @samtstern @yuchenshi ?

[samtstern]

LGTM

[yuchenshi]

One last thing: please drop localhost:4000/functions -- that's not a real thing. And feel free to merge after that.

[yuchenshi]

FYI The first line seems missing on my side in the logs viewer. Not blocking, but I'm super curious why.

[abeisgoat]

@yuchenshi That's fixed over here. We were doing a super hack split up logs which were (almost) always in the format of ICON EMULATOR: MESSAGE to cut off the ICON part and move it into the button in the adjacent column.

However, now we ship the log in chunks so there's no string parsing involved and cases where the string doesn't fit that format no longer break.

[yuchenshi]

Okay, I think this PR is good to go once we merge that PR and cut a release this afternoon.

[yuchenshi]

(FYI this is safe for releasing -- the link works in the GUI build I just cut.)