Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version number to package.json #263

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

jwngr
Copy link

@jwngr jwngr commented Feb 22, 2017

Description

Catapult (the internal tool we use to release Firebase JavaScript libraries) now works without the 0.0.0 version placeholder in the package.json file. So, we can finally add the actual version numbers back into this file.

Code sample

N/A

### Description

Catapult (the internal tool we use to release Firebase JavaScript libraries) now works without the `0.0.0` version placeholder in the `package.json` file. So, we can finally add the actual version numbers back into this file.

### Code sample

N/A
@coveralls
Copy link

coveralls commented Feb 22, 2017

Coverage Status

Coverage remained the same at 57.447% when pulling 01151b7 on w-add-version-numbers-to-json-files into 403f261 on master.

Copy link
Contributor

@cbraynor cbraynor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbraynor cbraynor assigned jwngr and unassigned cbraynor Feb 22, 2017
@jwngr jwngr merged commit c054b63 into master Feb 22, 2017
@jwngr jwngr deleted the w-add-version-numbers-to-json-files branch February 22, 2017 19:02
laurenzlong pushed a commit that referenced this pull request Apr 6, 2018
…263)

* Add asynchronous file utilies. Will let us stop using fstreamIgnore
* Simplify/promisify functions upload code; remove 3 node deps
* Fix race where we listened to the wrong pipe
* Fix sample repo to be one we own
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants