Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes database:remove command #2657

Merged
merged 2 commits into from Sep 30, 2020
Merged

Fixes database:remove command #2657

merged 2 commits into from Sep 30, 2020

Conversation

sarajmunjal
Copy link
Contributor

@sarajmunjal sarajmunjal commented Sep 30, 2020

Description

Fix database:remove command b/169565783
Earlier we were passing two arguments to utils.databaseUrl which led to the error The "url" argument must be of type string. Received undefined.

Scenarios Tested

firebase database:remove /somePath --instance <instance> --project <project>

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Sep 30, 2020
Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@sarajmunjal sarajmunjal merged commit 1078a8a into master Sep 30, 2020
@sarajmunjal sarajmunjal deleted the saraj/fix-rtdb-rm branch September 30, 2020 17:35
@sarajmunjal sarajmunjal changed the title Fix database:remove command Fixes database:remove command Sep 30, 2020
@pfinazzo
Copy link

pfinazzo commented Oct 1, 2020

Hi there I noticed this was merged yesterday! I am running into this issue right now, and was wondering when this fix will be deployed to npm so I can update it! Need this command to delete some large refs on our db. Thanks! 👍

@pfinazzo
Copy link

pfinazzo commented Oct 1, 2020

actually nevermind I will use --data null on set command for now. Thanks though!

@pfinazzo
Copy link

pfinazzo commented Oct 1, 2020

ah actually nevermind again, I do still need this updated, I just installed the latest binary and issue is still happening for me :/ problem is I cant use database:set because of the size limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants