[cleanup] remove unexpected awaits
#2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
reviewed
Nov 11, 2020
| @@ -424,7 +424,7 @@ export class FunctionsEmulator implements EmulatorInstance { | |||
| added = await this.addPubsubTrigger(this.args.projectId, definition); | |||
| break; | |||
| case Constants.SERVICE_AUTH: | |||
| added = await this.addAuthTrigger(this.args.projectId, definition); | |||
| added = this.addAuthTrigger(this.args.projectId, definition); | |||
There was a problem hiding this comment.
This one is a bit suspicious to me. I guess because auth is in-process it can be added synchronously?
There was a problem hiding this comment.
yup - it's a sync function, not async, so no need to await
samtstern
reviewed
Nov 11, 2020
yuchenshi
reviewed
Nov 11, 2020
| @@ -25,7 +25,7 @@ export interface FunctionProxyRewrite { | |||
| export default function( | |||
| options: FunctionsProxyOptions | |||
| ): (r: FunctionProxyRewrite) => Promise<RequestHandler> { | |||
| return async (rewrite: FunctionProxyRewrite) => { | |||
| return (rewrite: FunctionProxyRewrite) => { | |||
There was a problem hiding this comment.
nit: You may want to wrap the whole function body around new Promise to keep the behavior the same. Before, any errors in the function body will be returned as a rejected Promise. Now it just synchronously throws (which can be really bad), unless you wrap everything.
There was a problem hiding this comment.
Makes sense. I'll wrap it. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the
await-thenablewarning and fixing all the errors.Scenarios Tested