New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bucket filtering in the functions emulator #3893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…ly fixed the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but would love to have @abeisgoat review.
expect(test.storageBucketV2MetadataTriggerCount).to.equal(1); | ||
expect(test.storageBucketDeletedTriggerCount).to.equal(0); | ||
expect(test.storageBucketV2DeletedTriggerCount).to.equal(0); | ||
test.resetCounts(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside* I'd like to see this function be called in afterEach
hook, but I see that this isn't possible due to the way the test cases are structured today :/.
Love the comprehensive tests, looks good to me. |
* added filtering * change to use headers * using data attribute instead of header & adding integration tests * adding default-bucket into tests * local testing keeps failing, trying again on github workflows.... * removed 'default-bucket', added reset counter to framework, and finally fixed the tests * add changelog entry
Feature change to add bucket filtering to the functions emulator from storage events. Checks if
proto.data.bucket
exists in the multicast handler and appends additional content to the trigger key. This change includes a set of trigger integration tests.