Moved Storage rules integration tests under scripts/ #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohhsinpei
force-pushed
the
hsinpei/temp-skip-manager-test-2
branch
from
f185e4f
to
48c5d2c
Compare
tohhsinpei
added a commit
that referenced
this pull request
Mar 16, 2022
tohhsinpei
added a commit
that referenced
this pull request
Mar 16, 2022
tohhsinpei
added a commit
that referenced
this pull request
Mar 16, 2022
…rgets (#4281) * Address PR feedback; add JSDocs for new method * Make StorageRulesManager an interface; add StorageRulesManagerRegistry * Modify RulesetProvider to take resource parameter * Rebase; fix lint error * Change emulator arg to take SourceFile only * PR feedback, mostly re: API usage * Don't delete source file or ruleset on stop(); add CHANGELOG * Address PR feedback * Moved Storage rules integration tests under scripts/ (#4309) * Make StorageRulesManager an interface; add StorageRulesManagerRegistry * Modify RulesetProvider to take resource parameter * Change emulator arg to take SourceFile only * PR feedback, mostly re: API usage * Don't delete source file or ruleset on stop(); add CHANGELOG * Address PR feedback * Fix lint * Add test for failing to find rules for given resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #4297 (and #3233). Previously, we disabled the Storage rules unit tests because they were failing on deploy. This is because our deploy pipeline doesn't support
java, which is needed to run the rules JAR. However, unit tests should not be downloading and spinning up a JAR in the first place. We therefore move them toscripts/, where integration tests live.Sample Commands
npm run test:storage-emulator-integrationwill run these tests beforestorage-emulator-integration/tests.ts.