Reprompt if a non-existent public directory is used in firebase init command. #48
Conversation
| @@ -23,7 +23,7 @@ var defaultSettings = { | |||
|
|
|||
| function getPrompt(argv, schema, onComplete, index, results) { | |||
| if (!Array.isArray(schema)) { | |||
| console.log(chalk.red('An error occurred')); | |||
| console.log(chalk.red('getPrompt schema must be an Array.')); | |||
There was a problem hiding this comment.
This isn't useful to the average developer running firebase-tools, in fact it's pretty confusing. This repo needs a lot of work on messaging, but I don't think this is at all helpful here
There was a problem hiding this comment.
My understanding is that it is a debug message. Our users can never see this even for invalid inputs. So, I just changed that to something we can use for debugging. Do you want me to revert it ?
There was a problem hiding this comment.
Ok, that's a fair point. Lets leave it as what you have here - we need a complete messaging overhaul soon
|
A few comments, back to you. Given the lack of tests anyway, ignore the coveralls failure above |
| }, | ||
| conform: function(value) { | ||
| if (path.relative('.', value).match(/^\./)) { | ||
| schemaPublic.message = 'Please ensure the specified public directory is within the current working directory'; |
There was a problem hiding this comment.
Please use a directory within the current working directory
Reprompt if a non-existent public directory is used in firebase init command.
Consolidate all deploy:* commands with deploy --only <targets>
fyi: @jwngr