Fix storage gcs conformance tests #4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4869 +/- ##
==========================================
- Coverage 56.93% 56.73% -0.20%
==========================================
Files 288 288
Lines 19062 19110 +48
Branches 3775 3792 +17
==========================================
- Hits 10853 10843 -10
- Misses 7290 7350 +60
+ Partials 919 917 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
abhis3
reviewed
Aug 16, 2022
scripts/storage-emulator-integration/conformance/firebase-js-sdk.test.ts
Outdated
Show resolved
Hide resolved
* deploy working with using the default compute sa & running a GET request * fix test cases * formatter * cleaning up code post merge * add changelog entry
…ckend (#4873) * Only start eventarc emulator when there is at least one emulatable backend * Enable automatic port finding * Add changelog * Format changelog
Yuangwang
reviewed
Aug 16, 2022
scripts/storage-emulator-integration/conformance/firebase.endpoints.test.ts
Outdated
Show resolved
Hide resolved
scripts/storage-emulator-integration/conformance/firebase.endpoints.test.ts
Outdated
Show resolved
Hide resolved
scripts/storage-emulator-integration/conformance/gcs.endpoints.test.ts
Outdated
Show resolved
Hide resolved
bkendall
requested changes
Aug 16, 2022
bkendall
approved these changes
Aug 16, 2022
Yuangwang
approved these changes
Aug 16, 2022
christhompsongoogle
pushed a commit
that referenced
this pull request
Sep 30, 2022
* move * copy * move * save * pull out firebase and gcs tests * internal * env * gcs sdk tests * clean * remove tests.ts * lint * remove redundant config * persistence * remove creds * lint * gcs endpoint auth * fix firebase conformance tests * revert * clean * shrinkwrap * no async * merge * remove * fix test and lint * lint * multipart * fix tests * save * fix tests * fix metadata * revert package * fix * lint * Support CEL expressions in the v1alpha1 wire format provided by the SDK (#4809) * Add v2 Schedule Triggers to deploy (#4764) * deploy working with using the default compute sa & running a GET request * fix test cases * formatter * cleaning up code post merge * add changelog entry * Only start eventarc emulator when there is at least one emulatable backend (#4873) * Only start eventarc emulator when there is at least one emulatable backend * Enable automatic port finding * Add changelog * Format changelog * Persist CF3 param values to disk, and read them if available during deploy (#4787) * 11.7.0 * [firebase-release] Removed change log and reset repo after 11.7.0 release * revert js sdk tests * fix tests * comments * remove mocha * remove deep eql * revert shrinkwrap * changelog * lint Co-authored-by: Victor Fan <vsfan@google.com> Co-authored-by: Cole Rogers <colerogers@users.noreply.github.com> Co-authored-by: huangjeff5 <64040981+huangjeff5@users.noreply.github.com> Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/storage/v1/b/:bucketId/o/:objectIdurl patternScenarios Tested
Sample Commands