Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error location when parsing invalid firebase.json file. #49

Merged
merged 5 commits into from
Jun 3, 2015

Conversation

tamalsaha
Copy link
Contributor

fyi: @drtriumph @tomlarkworthy

@coveralls
Copy link

Coverage Status

Coverage remained the same at 5.54% when pulling 799dc73 on tml-json-ln into b496ec7 on master.

@tamalsaha tamalsaha assigned jwngr and unassigned tomlarkworthy May 28, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 5.54% when pulling 5cb741c on tml-json-ln into b496ec7 on master.

@jwngr jwngr assigned cbraynor and unassigned jwngr Jun 1, 2015
@jwngr
Copy link

jwngr commented Jun 1, 2015

Hot potato. Sending this over to Chris to review.

@cbraynor cbraynor assigned tamalsaha and unassigned cbraynor Jun 3, 2015
@cbraynor
Copy link
Contributor

cbraynor commented Jun 3, 2015

Waiting for testing on all the platforms and converting char location to line/char location

@coveralls
Copy link

Coverage Status

Coverage remained the same at 5.52% when pulling 0221b13 on tml-json-ln into f093986 on master.

@tamalsaha tamalsaha assigned cbraynor and unassigned tamalsaha Jun 3, 2015
@tamalsaha
Copy link
Contributor Author

@drtriumph This pull request has been tested on all 3 platforms.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 5.51% when pulling d67501e on tml-json-ln into f093986 on master.

cbraynor pushed a commit that referenced this pull request Jun 3, 2015
Report error location when parsing invalid firebase.json file.
@cbraynor cbraynor merged commit d02ef11 into master Jun 3, 2015
@cbraynor cbraynor deleted the tml-json-ln branch June 3, 2015 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants