Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing message on deploy #5109

Merged
merged 4 commits into from Oct 11, 2022
Merged

fix missing message on deploy #5109

merged 4 commits into from Oct 11, 2022

Conversation

bkendall
Copy link
Contributor

@bkendall bkendall commented Oct 11, 2022

Description

The message was dropped (because Options was removed?) on release. This restores that functionality and adds tests!

Scenarios Tested

image

Fixes #5107

@bkendall bkendall requested a review from inlined October 11, 2022 20:29
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 56.09% // Head: 56.18% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (36b250d) compared to base (b50317a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5109      +/-   ##
==========================================
+ Coverage   56.09%   56.18%   +0.08%     
==========================================
  Files         308      308              
  Lines       20700    20703       +3     
  Branches     4188     4189       +1     
==========================================
+ Hits        11611    11631      +20     
+ Misses       8082     8064      -18     
- Partials     1007     1008       +1     
Impacted Files Coverage Δ
src/deploy/hosting/release.ts 92.85% <100.00%> (+68.85%) ⬆️
src/hosting/api.ts 82.23% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/hosting/api.ts Outdated Show resolved Hide resolved
@bkendall bkendall merged commit 6eed1c2 into master Oct 11, 2022
@bkendall bkendall deleted the bk-5107 branch October 11, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase Hosting: firebase deploy ignores the -m argument in version 11.14.1
4 participants