Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop trying other ports given EADDRNOTAVAIL. #5115

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Conversation

yuchenshi
Copy link
Member

Description

Follow-up to #5112.

Scenarios Tested

TBD

Sample Commands

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Base: 56.16% // Head: 56.17% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (25378a5) compared to base (e2b6a89).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5115      +/-   ##
==========================================
+ Coverage   56.16%   56.17%   +0.01%     
==========================================
  Files         308      308              
  Lines       20710    20711       +1     
  Branches     4192     4191       -1     
==========================================
+ Hits        11631    11634       +3     
+ Misses       8070     8069       -1     
+ Partials     1009     1008       -1     
Impacted Files Coverage Δ
src/emulator/portUtils.ts 49.24% <25.00%> (+0.38%) ⬆️
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants