assign Hosting port using portUtils #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
approved these changes
Oct 13, 2022
Codecov ReportBase: 56.16% // Head: 56.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5119 +/- ##
=======================================
Coverage 56.16% 56.16%
=======================================
Files 308 308
Lines 20711 20714 +3
Branches 4191 4194 +3
=======================================
+ Hits 11632 11634 +2
+ Misses 8071 8070 -1
- Partials 1008 1010 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of relying on custom port-finding logic in the Hosting emulator, utilize the portUtils from the emulator to get a port. Additionally, report back the port that is used to the Hosting emulator's registry information, which will allow the registry to correctly see that the Hosting emulator has started.
Scenarios Tested
A setup with Hosting + Functions works wonderfully, so does a Next.js app that starts functions along side Hosting. (all on macOS)