Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function deploy integration test. #5204

Merged
merged 2 commits into from
Nov 3, 2022
+4 −1
Merged

Fix function deploy integration test. #5204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ab1628
Fix integration test.
taeold Nov 2, 2022
1f995e3
Merge branch 'master' into dl-cf3-integration-fix
taeold Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/functions-deploy-tests/tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,10 @@ describe("firebase deploy", function (this) {
if (e.platform === "gcfv2") {
expect(e).to.include({
cpu: 2,
concurrency: 42,
// EXCEPTION: concurrency
// Firebase will aggressively set concurrency to 80 when the CPU setting allows for it
// AND when the concurrency is NOT set on the source code.
concurrency: 80,
});
}
// BUGBUG: As implemented, Cloud Tasks update doesn't preserve existing setting. Instead, it overwrites the
Expand Down