Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject FIREBASE_CONFIG environment variable for scripts executed via emulators:exec command. #5544

Merged
merged 4 commits into from
Feb 23, 2023

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Feb 22, 2023

As discussed in #5536 (comment), we learned that old versions of Firebase Functions SDK always made process.env.FIREBASE_CONFIG available to the underlying script that imported the Firebase Functions SDK.

While making process.env.FIREBASE_CONFIG available wasn't intentional, we'll consider this a case of Hyrum's Law and will try our best to fix the regression by making process.env.FIREBASE_CONFIG environment variable available if not set in the parent process.

Fixes #5536

@taeold taeold enabled auto-merge (squash) February 23, 2023 19:18
@taeold taeold merged commit cc889a5 into master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate FIREBASE_CONFIG environment variable for scripts executed via emulators:exec
2 participants