Updated expectedSize and expectedChecksum #5737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if you can put some check in place to prevent this in future? |
|
This was an odd one - we have tests in place to catch this, but we changed the JAR after running them. Ended up fixing this issue by putting the correct JAR in storage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposed fix for #5734.
Looks like the cause is the incorrect expectedSize and expectedChecksum here.
expectedSizeis 64723779 andexpectedChecksumis 963b46bce1a2f8ca5dfc504ab7b2c901.Scenarios Tested
.cache/firebase/emulators/cloud-firestore-emulator-v1.17.2.jar.firebase emulators:start --project demo-proj --only firestoreto re-install the emulator.