Speed up functions deployment by doing in-place trigger parsing #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 22, 2017 15:52
mbleigh
approved these changes
Jan 2, 2018
lib/prepareFunctionsUpload.js
Outdated
| return parseTriggers(getProjectId(options), tmpdir.name); | ||
| var configValues; | ||
| var sourceDir = options.config.path(options.config.get('functions.source')); | ||
| return _prepareSource(context).then(function(result) { |
There was a problem hiding this comment.
It's kinda weird that a function called prepareSource resolves with config values. Can we refactor this just a bit now that "preparing source" isn't copying things to a tmp dir?
|
|
|
LGTM |
yuchenshi
added a commit
that referenced
this pull request
Aug 5, 2020
* Add delete and config emulator util APIs. * Clean up typos and linter warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #536.
Speeds up functions deployment:
.runtimeconfig.json. The config variables are put inside an environment variable so that trigger parsing will still work, and are stuffed into the archive right before uploading. (must be used with Overload process.env.CLOUD_RUNTIME_CONFIG to be JSON or path to JSON firebase-functions#155 version of firebase-functions)This has been manually tested, deploy works as expected, and the uploaded source zip contains .runtimeconfig.json with the correct config values.
Sample Commands
No change to commands.