Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Cloud storage bucket metadata location type (mutli-region) (#6648) #6649

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

crashdump
Copy link
Contributor

@crashdump crashdump commented Dec 29, 2023

This is a fix for a simple typo, see ticket #6648

Copy link

google-cla bot commented Dec 29, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@tonyjhuang tonyjhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tonyjhuang tonyjhuang enabled auto-merge (squash) January 2, 2024 22:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5a46646) 54.17% compared to head (703c30f) 54.18%.

Files Patch % Lines
src/emulator/storage/metadata.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6649   +/-   ##
=======================================
  Coverage   54.17%   54.18%           
=======================================
  Files         347      347           
  Lines       24130    24130           
  Branches     4976     4976           
=======================================
+ Hits        13073    13075    +2     
+ Misses       9857     9855    -2     
  Partials     1200     1200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonyjhuang tonyjhuang merged commit 36311ea into firebase:master Jan 2, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants