Astro adapter proof of concept #7210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoortizz
reviewed
Jun 4, 2024
src/frameworks/astro/index.ts
Outdated
Comment on lines
29
to
37
| let bundleConfig: BundleConfig; | ||
| async function getBundleConfigs(cwd: string): Promise<BundleConfig> { | ||
| if (bundleConfig) { | ||
| return bundleConfig; | ||
| } | ||
|
|
||
| const fileContents = await readFile(join(cwd, ".apphosting", "bundle.yaml"), "utf8"); | ||
| return load(fileContents); | ||
| } |
There was a problem hiding this comment.
should we have this at frameworks/utils or it can be framework specific?
src/frameworks/astro/index.ts
Outdated
Comment on lines
49
to
51
| for (const assetPath of bundleConfigs.staticAssets) { | ||
| await copy(assetPath, dest); | ||
| } |
There was a problem hiding this comment.
probably better to Promise.all?
Suggested change
| for (const assetPath of bundleConfigs.staticAssets) { | |
| await copy(assetPath, dest); | |
| } | |
| await Promise.all(bundleConfigs.staticAssets.map((assetPath) => copy(assetPath, dest))); |
src/frameworks/astro/index.ts
Outdated
| const packageJson = await readJSON(join(sourceDir, "package.json")); | ||
| await copy(join(sourceDir, outDir, "server"), join(destDir)); | ||
| if (bundleConfigs.serverDirectory != null) { |
There was a problem hiding this comment.
Suggested change
| if (bundleConfigs.serverDirectory != null) { | |
| if (bundleConfigs.serverDirectory) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have the web frameworks astro framework support be pulled in from the apphosting adapter.
This is the companion pr for FirebaseExtended/firebase-framework-tools#195, FirebaseExtended/firebase-framework-tools#195 should be merged in before this current pr is merged in
Scenarios Tested
Sample Commands