Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataconnect e2e test to CI #7242

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Add dataconnect e2e test to CI #7242

merged 4 commits into from
Jun 7, 2024

Conversation

joehan
Copy link
Contributor

@joehan joehan commented May 31, 2024

Description

Add test:dataconnect-deploy to our CI. Once this is passing consistently, I'll also add it to the required checks and it will block merging if it fails.

I do need to add the target project to our allowlist before this will pass. Somehow, I never got access to that project in the handoff from @bkendall, so looking around for someone who does have access so I can grab the project number

@joehan joehan requested a review from bkendall May 31, 2024 22:02
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.05%. Comparing base (06cb833) to head (45f60c0).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7242      +/-   ##
==========================================
- Coverage   54.06%   54.05%   -0.01%     
==========================================
  Files         386      386              
  Lines       26137    26137              
  Branches     5370     5369       -1     
==========================================
- Hits        14131    14129       -2     
- Misses      10742    10743       +1     
- Partials     1264     1265       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joehan joehan requested a review from fredzqm June 4, 2024 20:50
@joehan joehan enabled auto-merge (squash) June 4, 2024 20:51
@fredzqm fredzqm disabled auto-merge June 4, 2024 21:32
@fredzqm fredzqm enabled auto-merge (squash) June 4, 2024 21:33
@fredzqm fredzqm merged commit 13ffce6 into master Jun 7, 2024
41 checks passed
@joehan joehan deleted the jh-dc-e2e-ci branch June 7, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants