Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issues with init dataconnect #7295

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fixing issues with init dataconnect #7295

merged 2 commits into from
Jun 7, 2024

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Jun 7, 2024

Description

Fixes 2 issues reported by testers for fresh from console instances:

  • dataconnect block was not added to firebase.json
  • Instance name was being written to dataconnect.yaml instead of instanceId when

Scenarios Tested

Fresh from console case:
Screenshot 2024-06-07 at 9 47 37 AM

@joehan joehan requested review from fredzqm and yuchenshi June 7, 2024 17:01
@joehan joehan enabled auto-merge (squash) June 7, 2024 17:01
@joehan joehan merged commit ead816b into master Jun 7, 2024
41 checks passed
@joehan joehan deleted the jh-init-fixez branch June 7, 2024 17:19
@joehan joehan requested review from yuchenshi and removed request for fredzqm June 7, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joehan @yuchenshi