init dataconnect:sdk and other SDK onboarding improvements #7299
Conversation
joehan
changed the title
| `Run ${clc.bold("firebase init dataconnect:sdk")} to configure a generated SDK.`, | ||
| ); | ||
| logger.warn( | ||
| `See https://firebase.google.com/docs/data-connect/quickstart#configure-sdk-outputs for more details of how to configure generated SDKs.`, |
There was a problem hiding this comment.
@markarndt FYI on the link.
It doesn't work right now. If you have a "future" link, that would be neat.
There was a problem hiding this comment.
Dang, this link previously worked, looks like we edited that page recently. Linking to https://firebase.google.com/docs/data-connect/gp/web-sdk instead for now, but feel free to edit suggest a better link @markarndt
| @@ -96,6 +99,10 @@ export async function doSetup(setup: Setup, config: Config): Promise<void> { | |||
| waitForCreation: false, | |||
| }); | |||
| } | |||
| logger.info(""); | |||
There was a problem hiding this comment.
Did you forget to remove this?
There was a problem hiding this comment.
Nope, added this to space out the next message a little better so it is more visible
src/commands/init.ts
Outdated
| @@ -85,6 +85,11 @@ choices.push({ | |||
| name: "Data Connect: Set up a Firebase Data Connect service.", | |||
| checked: false, | |||
| }); | |||
| choices.push({ | |||
| value: "dataconnect:sdk", | |||
| name: "Data Connect: Set up a generated SDK for your Firebase Data Connect service.", | |||
There was a problem hiding this comment.
Data Connect SDK: Set up a generated SDK for your Firebase Data Connect service.
There was a problem hiding this comment.
Followed the pattern used by hosting here, which has 2 init options:
|
Did a test run. Looks amazing! 
|
| # swiftSdk: | ||
| # outputDir: <Path where you want the generated SDK to be written to, relative to this file> | ||
| # kotlinSdk: | ||
| # outputDir: <Path where you want the generated SDK to be written to, relative to this file> |
There was a problem hiding this comment.
nit: add "package" under "kotlinSdk" to specify the kotlin package to incorporate into the generated kotlin code.
Description
init dataconnect:sdkto help guide users on how to configure their generated SDKs.init dataconnectconnector.yamlScenarios Tested
I tested out adding SDKs of each type. I also confirmed that if you run this with existing SDKs configured, we default to the values you already have configured.