Better handling of connection string #7339
Conversation
…if no connection string is set.
joehan
requested review from
yuchenshi and
fredzqm
and removed request for
yuchenshi
| message: `What is the connection string of the local Postgres instance you would like to use with the Data Connect emulator?`, | ||
| default: defaultConnectionString, | ||
| }); | ||
| options.rc.setDataconnect(localConnectionString); |
There was a problem hiding this comment.
So we decide to keep firebase setup:emulators:dataconnect instead of firebase init emulators dataconnect.
You probably know a lot more than I do on this. Is this a common pattern?
[non-blocking]
init emulators also setup port and other things. Do you think it make sense to include them or somehow re-use?
There was a problem hiding this comment.
We have both commands for all of the (downloadable) emulators - I went with suggesting firebase setup:emulators:dataconnect for this one because it was an easier 1 liner than init emulators, and we do not support init emulators <productName> (and doing so would require an API proposal + a surprising amount of rewiring in init)
I did a bit of digging, and the raison d'etre for setup:emulators:product is for use in CI/CD environment set up scripts (ie Docker files or as a cached Github action step). 'init' doesn't work in these environments because it is interactive only. With that in mind, I've gated the prompt so that it only happens in interactive environments.
I omitted port configuration to match other setup:emulators:<product> commands. I also don't think they are relevant for most users.
Description
This PR does 2 things:
Scenarios Tested
Running 'firebase setup:emulators:dataconnect' from outside a project directory, then inside a project directory
Try to start emulator with a connection string configured, error out, run the suggested command, and then successfully run the emulator
