Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows paths should use forward slash #869

Merged
merged 3 commits into from
Aug 15, 2018
Merged

Windows paths should use forward slash #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11d2cd0
Windows paths should use forward slash
Aug 15, 2018
6c13532
Bumping patch version
Aug 15, 2018
7b7c463
Updating changelog
Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fixed - Windows path separator should use a forward slash.
7 changes: 3 additions & 4 deletions lib/deploy/hosting/uploader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,10 @@ class Uploader {
}

addHash(filePath, hash) {
const npath = path.relative(this.public, path.resolve(this.public, filePath));
this.hashMap[hash] = npath;
this.pathMap[npath] = hash;
this.hashMap[hash] = filePath;
this.pathMap[filePath] = hash;

this.populateBatch["/" + npath] = hash;
this.populateBatch["/" + filePath] = hash;
this.populateCount++;

const curBatchSize = size(this.populateBatch);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "firebase-tools",
"version": "4.1.0",
"version": "4.1.1",
"description": "Command-Line Interface for Firebase",
"main": "index.js",
"bin": {
Expand Down