Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pour one out for the fire emoji banner. #973

Merged
merged 1 commit into from Oct 26, 2018
Merged

Pour one out for the fire emoji banner. #973

merged 1 commit into from Oct 26, 2018

Conversation

mbleigh
Copy link
Contributor

@mbleigh mbleigh commented Oct 26, 2018

Ever since <insert version of macOS here, don't remember> the beautiful FIREBASE emoji banner has been wrecked in the default OS X Terminal app due to UTF-8 character spacing changes. Other terminals like Hyper or iTerm work fine, but there's no way that I was able to determine to detect where it will and won't work. 馃槥

Since a yellow FIREBASE is better than a glitchy mess, it's time to say goodbye to the fire emoji. Thanks a lot, 馃崕

馃挧馃挧馃挧馃挧馃敟馃挧馃挧馃挧馃挧

Copy link
Contributor

@ryanpbrewster ryanpbrewster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槶

@mbleigh mbleigh merged commit 8bdaa9e into master Oct 26, 2018
@mbleigh mbleigh deleted the mb-banner branch October 26, 2018 01:11
@ghost
Copy link

ghost commented Oct 26, 2018

馃槩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants