Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deployments of other directory via code #976

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Fix deployments of other directory via code #976

merged 1 commit into from
Oct 26, 2018

Conversation

bkendall
Copy link
Contributor

Description

Pass working directory through to the uploader when deploying via code.

fixes #961

Scenarios Tested

  • tested a deploy via code (like the readme)
  • linked and used the CLI to deploy

@bkendall bkendall requested a review from mbleigh October 26, 2018 03:30
@bkendall bkendall mentioned this pull request Oct 26, 2018
Closed
@bkendall bkendall merged commit effe27e into master Oct 26, 2018
@bkendall bkendall deleted the bk-deploy-fix branch November 20, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbleigh mbleigh mbleigh approved these changes

Assignees

@mbleigh mbleigh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy programmatically with option cwd doesn't work in version 4.2.1 and 5.1.1
2 participants
@bkendall @mbleigh