Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing information of localized build for Typescript users. #815

Closed
ferrywlto opened this issue Feb 11, 2021 · 2 comments · Fixed by #816
Closed

Missing information of localized build for Typescript users. #815

ferrywlto opened this issue Feb 11, 2021 · 2 comments · Fixed by #816

Comments

@ferrywlto
Copy link
Contributor

ferrywlto commented Feb 11, 2021

In our project we are using Typescript with Vue and need to support Traditional Chinese language (zh-TW) locale. Since Typescript requires type checking to work. Dynamically create and append script tag to load the localized version is not an option. Therefore we need to pull the repo and build by our own. Following the README.md doesn't work for us, with firebaseui__zh_tw.js and npm__zh_tw.js, the UI were still in English (en), when inspected the element was still look like this:

<div id="firebase-auth-container" lang="en">

After a few hours of trial and error we find that esm.js was the file we actually needed to be localized. However the README.md didn't mention we can instead build the localized version of esm.js via yarn build build-esm-zh-tw as well. I think this information will help both the new user of firebaseui and TypeScript a lot.

Would the repo owner mind I do a PR to update the README.md with steps on how I successfully build, import and use the localized version?

Below is my successful screenshot:
image
image

@bojeil-google
Copy link
Contributor

bojeil-google commented Feb 11, 2021

Thanks, @ferrywlto. Feel free to send a PR to update the README file with the additional instructions.

@brycehuang30
Copy link

I follow the removed instruction
It works! Thanks a lot @ferrywlto !

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants