Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release3.4.1 #502

Merged
merged 2 commits into from Sep 11, 2018
Merged

Release3.4.1 #502

merged 2 commits into from Sep 11, 2018

Conversation

wti806
Copy link
Contributor

@wti806 wti806 commented Sep 11, 2018

Release V3.4.1:

  • Hides cancel button in phone sign-in page if only phone provider is configured.
  • Reverts FirebaseUI languageCode modification on external Auth instance before sign in completion to not trigger race conditions when signInSuccessWithAuthResult callback modifies the Auth languageCode.

@wti806
- Hides cancel button in phone sign-in page if only phone provider is…
9faf039 
… configured.

- Reverts FirebaseUI languageCode modification on external Auth instance before sign in completion to not trigger race conditions when signInSuccess callback modifies the Auth languageCode.
- Opening the window with target '_system' if cordova InAppBrowser plugin is installed for tos/pp.
- Sync readme change from GitHub repo.

PiperOrigin-RevId: 212489380
Change-Id: Ib4288a3661449a61d9ee3d3489f4787010ad05b2
@wti806
update readme and changelog
e74d6de
@wti806 wti806 merged commit 08ef4b9 into master Sep 11, 2018
@wti806 wti806 deleted the release3.4.1 branch July 16, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojeil-google bojeil-google bojeil-google approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wti806 @bojeil-google