fix(firebase_ui_oauth): Made ThemedOAuthProviderButtonStyle.iconPaddi…

…ng work
firebase · Dec 1, 2022 · 5f2002f · 5f2002f
1 parent d796d33
commit 5f2002f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/packages/firebase_ui_oauth/lib/src/oauth_provider_button_base.dart b/packages/firebase_ui_oauth/lib/src/oauth_provider_button_base.dart
@@ -189,6 +189,7 @@ class _OAuthProviderButtonBaseState extends State<OAuthProviderButtonBase>
               child: _ButtonContent(
                 assetsPackage: style.assetsPackage,
                 iconSrc: style.iconSrc,
+                iconPadding: style.iconPadding,
                 isLoading: isLoading,
                 label: widget.label,
                 height: _height,
@@ -228,6 +229,7 @@ class _OAuthProviderButtonBaseState extends State<OAuthProviderButtonBase>
           _ButtonContent(
             assetsPackage: style.assetsPackage,
             iconSrc: style.iconSrc,
+            iconPadding: style.iconPadding,
             isLoading: isLoading,
             label: widget.label,
             height: _height,
@@ -363,6 +365,7 @@ class _OAuthProviderButtonBaseState extends State<OAuthProviderButtonBase>
 class _ButtonContent extends StatelessWidget {
   final double height;
   final String iconSrc;
+  final double iconPadding;
   final String assetsPackage;
   final String label;
   final bool isLoading;
@@ -377,6 +380,7 @@ class _ButtonContent extends StatelessWidget {
     Key? key,
     required this.height,
     required this.iconSrc,
+    required this.iconPadding,
     required this.assetsPackage,
     required this.label,
     required this.isLoading,
@@ -398,10 +402,13 @@ class _ButtonContent extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    Widget child = SvgPicture.string(
-      iconSrc,
-      width: height,
-      height: height,
+    Widget child = Padding(
+      padding: EdgeInsets.all(iconPadding),
+      child: SvgPicture.string(
+        iconSrc,
+        width: height,
+        height: height,
+      ),
     );
 
     if (label.isNotEmpty) {

diff --git a/packages/firebase_ui_oauth/lib/src/oauth_provider_button_style.dart b/packages/firebase_ui_oauth/lib/src/oauth_provider_button_style.dart
@@ -57,6 +57,7 @@ abstract class ThemedOAuthProviderButtonStyle {
   OAuthProviderButtonStyle withBrightness(Brightness brightness) {
     return OAuthProviderButtonStyle(
       iconSrc: iconSrc.getValue(brightness),
+      iconPadding: iconPadding,
       backgroundColor: backgroundColor.getValue(brightness),
       color: color.getValue(brightness),
       borderColor: borderColor.getValue(brightness),
@@ -68,6 +69,7 @@ abstract class ThemedOAuthProviderButtonStyle {
 
 class OAuthProviderButtonStyle {
   final String iconSrc;
+  final double iconPadding;
   final Color backgroundColor;
   final Color color;
   final Color borderColor;
@@ -76,6 +78,7 @@ class OAuthProviderButtonStyle {
 
   OAuthProviderButtonStyle({
     required this.iconSrc,
+    required this.iconPadding,
     required this.backgroundColor,
     required this.color,
     required this.borderColor,